Files
crypto/bls/bls_c.go
T
zeekay 9a71af427f bls: harden the deserialization + aggregation boundary (HIGH-1, RESIDUAL-C, identity-aggregate)
Three additive, fail-closed hardenings on the BLS boundary, with the security-
critical regressions on the purego (CIRCL, //go:build !cgo) path — the canonical
CGO_ENABLED=0 node image:

HIGH-1 (panic-DoS). CIRCL's bls12381 G1/G2 SetBytes accepts the MALFORMED
encoding 'infinity bit set, compression bit clear' (top byte b[0]&0xC0 == 0x40):
it computes the UNCOMPRESSED length and slices b[1:96]/b[1:192] on a canonical
48/96-byte COMPRESSED buffer -> slice-bounds-out-of-range PANIC. On a purego node a
single 0x40||zeros blob in a proof-of-possession / peer-handshake / warp / quasar
BLS field is an unauthenticated, consensus-halting DoS. Reject b[0]&0xC0 == 0x40 at
the compressed length BEFORE SetBytes, in-band (not recover()), restoring parity
with blst's erroring Uncompress. Guards: PublicKeyFromCompressedBytes,
SignatureFromBytes. Regression: sig_infinity_unset_compression_test.go.

RESIDUAL-C (identity at one boundary). Move identity rejection to the SINGLE
deserialization boundary: PublicKeyFromCompressedBytes / FromValidUncompressedBytes
call Validate()/KeyValidate() (= !IsIdentity() && on-curve && in-subgroup), so an
identity (or off-curve) key never escapes a constructor. Verify/VerifyProofOfPossession
drop their redundant per-call identity test — which was WRONG anyway (it compared
against 0x00||zeros; the canonical compressed-G1 infinity is 0xc0||zeros, so it
never matched). FromValidUncompressedBytes now actually validates (was a silent
_ = UnmarshalBinary).

Identity-aggregate (defence in depth). AggregatePublicKeys now rejects an aggregate
that is the IDENTITY (point at infinity). Each input is a valid non-identity
subgroup key, and the subgroup is closed under addition — but the sum can still be
O when inputs sum to zero (the rogue-key shape pk + (-pk) = O). An identity
aggregate public key makes Verify trivially accept the identity signature (a forgery
enabler). PoP at registration already blocks an attacker contributing an
unpossessed key, but the verifier must not depend on that everywhere: purego
result.Validate() and cgo out.KeyValidate() fail the aggregate closed. Regression
(agg_identity_reject_test.go): pk + -pk must error; proven to FAIL without the guard
(returns a usable identity key); a legitimate two-key aggregate still succeeds.

Full bls suite green on both backends (CGO_ENABLED=0 and =1).
2026-06-22 22:26:49 -07:00

291 lines
8.7 KiB
Go

// Copyright (C) 2020-2025, Lux Industries Inc. All rights reserved.
// See the file LICENSE for licensing terms.
//go:build cgo
package bls
import (
"crypto/rand"
"errors"
"github.com/luxfi/crypto/secret"
blst "github.com/supranational/blst/bindings/go"
)
// Domain separation tags
var (
dstSignature = []byte("BLS_SIG_BLS12381G2_XMD:SHA-256_SSWU_RO_NUL_")
dstPoP = []byte("BLS_POP_BLS12381G2_XMD:SHA-256_SSWU_RO_POP_")
)
// Types wrapping the blst BLS types
type (
SecretKey struct {
sk *blst.SecretKey
}
PublicKey struct {
pk *blst.P1Affine
}
Signature struct {
sig *blst.P2Affine
}
AggregatePublicKey = PublicKey
AggregateSignature = Signature
)
// NewSecretKey generates a new secret key from the local source of
// cryptographically secure randomness.
func NewSecretKey() (*SecretKey, error) {
var result *SecretKey
secret.Do(func() {
ikm := make([]byte, 32)
rand.Read(ikm)
defer clear(ikm)
result = &SecretKey{sk: blst.KeyGen(ikm)}
})
return result, nil
}
// SecretKeyToBytes returns the big-endian format of the secret key.
func SecretKeyToBytes(sk *SecretKey) []byte {
if sk == nil || sk.sk == nil {
return nil
}
return sk.sk.Serialize()
}
// SecretKeyFromSeed derives a secret key from a seed using proper BLS key derivation.
// The seed is passed through HKDF internally by blst.KeyGen, so any 32+ byte input
// will produce a valid secret key.
func SecretKeyFromSeed(seed []byte) (*SecretKey, error) {
if len(seed) < 32 {
return nil, errors.New("seed must be at least 32 bytes")
}
sk := blst.KeyGen(seed)
return &SecretKey{sk: sk}, nil
}
// SecretKeyFromBytes parses the big-endian format of the secret key into a
// secret key.
func SecretKeyFromBytes(skBytes []byte) (*SecretKey, error) {
if len(skBytes) != SecretKeyLen {
return nil, ErrFailedSecretKeyDeserialize
}
// Reject zero secret key (security: not a valid scalar)
allZero := true
for _, b := range skBytes {
if b != 0 {
allZero = false
break
}
}
if allZero {
return nil, ErrFailedSecretKeyDeserialize
}
var result *SecretKey
secret.Do(func() {
sk := new(blst.SecretKey)
sk.Deserialize(skBytes)
result = &SecretKey{sk: sk}
})
return result, nil
}
// PublicKey returns the public key associated with the secret key.
func (sk *SecretKey) PublicKey() *PublicKey {
if sk == nil || sk.sk == nil {
return nil
}
pk := new(blst.P1Affine)
pk.From(sk.sk)
return &PublicKey{pk: pk}
}
// Sign [msg] to authorize that this private key signed [msg].
func (sk *SecretKey) Sign(msg []byte) (*Signature, error) {
if sk == nil || sk.sk == nil {
return nil, errors.New("nil secret key")
}
sig := new(blst.P2Affine)
sig.Sign(sk.sk, msg, dstSignature)
return &Signature{sig: sig}, nil
}
// SignProofOfPossession signs a [msg] to prove the ownership of this secret key.
func (sk *SecretKey) SignProofOfPossession(msg []byte) (*Signature, error) {
if sk == nil || sk.sk == nil {
return nil, errors.New("nil secret key")
}
sig := new(blst.P2Affine)
sig.Sign(sk.sk, msg, dstPoP)
return &Signature{sig: sig}, nil
}
// PublicKeyToCompressedBytes returns the compressed big-endian format of the
// public key.
func PublicKeyToCompressedBytes(pk *PublicKey) []byte {
if pk == nil || pk.pk == nil {
return nil
}
return pk.pk.Compress()
}
// PublicKeyFromCompressedBytes parses the compressed big-endian format of the
// public key into a public key.
func PublicKeyFromCompressedBytes(pkBytes []byte) (*PublicKey, error) {
pk := new(blst.P1Affine)
pk = pk.Uncompress(pkBytes)
if pk == nil {
return nil, ErrFailedPublicKeyDecompress
}
if !pk.KeyValidate() {
return nil, ErrInvalidPublicKey
}
return &PublicKey{pk: pk}, nil
}
// PublicKeyToUncompressedBytes returns the uncompressed big-endian format of
// the public key.
func PublicKeyToUncompressedBytes(key *PublicKey) []byte {
if key == nil || key.pk == nil {
return nil
}
return key.pk.Serialize()
}
// PublicKeyFromValidUncompressedBytes parses the uncompressed big-endian format
// of the public key into a public key. It is assumed that the provided bytes
// are valid.
func PublicKeyFromValidUncompressedBytes(pkBytes []byte) *PublicKey {
pk := new(blst.P1Affine)
if pk.Deserialize(pkBytes) == nil {
return nil
}
// Identity rejection lives at the ONE deserialization boundary (RESIDUAL C):
// KeyValidate() rejects the infinity point (and off-curve / wrong-subgroup),
// so an identity key never escapes a constructor. Downstream Verify therefore
// does NOT re-check for the identity point — the check belongs here, once.
if !pk.KeyValidate() {
return nil
}
return &PublicKey{pk: pk}
}
// AggregatePublicKeys aggregates a non-zero number of public keys into a single
// aggregated public key.
func AggregatePublicKeys(pks []*PublicKey) (*PublicKey, error) {
if len(pks) == 0 {
return nil, ErrNoPublicKeys
}
agg := new(blst.P1Aggregate)
for _, pk := range pks {
if pk == nil || pk.pk == nil {
return nil, ErrInvalidPublicKey
}
if !agg.Add(pk.pk, true) {
return nil, ErrFailedPublicKeyAggregation
}
}
// Defence in depth: reject an aggregate that is the IDENTITY (point at
// infinity). Each INPUT key is a valid non-identity subgroup point (the
// constructors call KeyValidate), and the sum of subgroup points stays on-curve
// and in-subgroup — but it can still be the identity when the inputs sum to zero
// (the canonical rogue-key shape: pk + (-pk) = O). An identity aggregate public
// key makes Verify trivially accept the identity signature (a forgery enabler).
// blst's KeyValidate rejects the infinity point (and off-curve / wrong-subgroup),
// matching the purego path's result.Validate() — fail the aggregate closed rather
// than depend on proof-of-possession being enforced upstream everywhere.
out := agg.ToAffine()
if !out.KeyValidate() {
return nil, ErrFailedPublicKeyAggregation
}
return &PublicKey{pk: out}, nil
}
// Verify the [sig] of [msg] against the [pk].
func Verify(pk *PublicKey, sig *Signature, msg []byte) bool {
if pk == nil || pk.pk == nil || sig == nil || sig.sig == nil {
return false
}
// The identity (zero) public key is rejected at the deserialization boundary
// (PublicKeyFromCompressedBytes / PublicKeyFromValidUncompressedBytes call
// KeyValidate(), which rejects the infinity point), so a *PublicKey reaching
// Verify is already a valid non-identity G1 point. Re-checking here was
// redundant — and the old all-zero byte test was WRONG anyway (blst Compress()
// of the identity is 0xc0||zeros, not 0x00||zeros, so it never actually
// matched) — removed (RESIDUAL C): identity rejection belongs at decode, once.
return sig.sig.Verify(true, pk.pk, false, msg, dstSignature)
}
// VerifyProofOfPossession verifies the possession of the secret pre-image of [sk]
func VerifyProofOfPossession(pk *PublicKey, sig *Signature, msg []byte) bool {
if pk == nil || pk.pk == nil || sig == nil || sig.sig == nil {
return false
}
// Identity (zero) pubkey already rejected at decode (KeyValidate); see Verify.
return sig.sig.Verify(true, pk.pk, false, msg, dstPoP)
}
// SignatureToBytes returns the compressed big-endian format of the signature.
func SignatureToBytes(sig *Signature) []byte {
if sig == nil || sig.sig == nil {
return nil
}
return sig.sig.Compress()
}
// SignatureFromBytes parses the compressed big-endian format of the signature
// into a signature.
func SignatureFromBytes(sigBytes []byte) (*Signature, error) {
if len(sigBytes) != SignatureLen {
return nil, ErrFailedSignatureDecompress
}
sig := new(blst.P2Affine)
sig = sig.Uncompress(sigBytes)
if sig == nil {
return nil, ErrFailedSignatureDecompress
}
// SigValidate(true) checks BOTH r-torsion subgroup membership AND rejects the
// G2 identity (point at infinity) — go_p2_affine_validate(p, infcheck=true) is
// `if is_inf(p) return false; return in_g2(p)`. The prior SigValidate(false)
// skipped the infinity check, accepting the identity signature (INFO-4); this
// makes the blst path symmetric with the purego SignatureFromBytes identity
// reject and with the pubkey identity guard at decode (KeyValidate). The
// identity sig does not forge
// against a real key, but admitting a degenerate point into the verifier is an
// asymmetry worth closing.
if !sig.SigValidate(true) {
return nil, ErrInvalidSignature
}
return &Signature{sig: sig}, nil
}
// AggregateSignatures aggregates a non-zero number of signatures into a single
// aggregated signature.
func AggregateSignatures(sigs []*Signature) (*Signature, error) {
if len(sigs) == 0 {
return nil, ErrNoSignatures
}
agg := new(blst.P2Aggregate)
for _, sig := range sigs {
if sig == nil || sig.sig == nil {
return nil, ErrFailedSignatureAggregation
}
if !agg.Add(sig.sig, true) {
return nil, ErrFailedSignatureAggregation
}
}
return &Signature{sig: agg.ToAffine()}, nil
}