mirror of
https://github.com/luxfi/node.git
synced 2026-07-27 03:39:39 +00:00
node: ZAP-native everywhere — kill every //go:build grpc path
The companion commit `7496606282` retired the gRPC fallback inside
vms/rpcchainvm/. This commit closes the loop by deleting every
remaining `//go:build grpc` file under node/, removing the dual-build
plumbing entirely. ZAP is the only wire protocol; there is no
`-tags=grpc` opt-in.
Per the "one and only one way to do everything" mandate, the
backwards-compat scaffolding (gRPC adapters, protoc stubs, connect-go
example handlers, OTLP gRPC exporter, x/sync gRPC sync engine,
keystore-over-gRPC client/server, rpcwarp gRPC signer, gRPC alias
reader) is removed forward-only — no aliases, no deprecation period.
Deletions (84 files):
- proto/pb/{aliasreader,http,io,keystore,message,messenger,net,p2p,
platformvm,rpcdb,sdk,sender,sharedmemory,signer,sync,
validatorstate,vm,warp}/ — protoc stubs (entire tree)
- proto/{p2p,platformvm,sync,vm}/*_grpc.go — gRPC type re-exports
- db/rpcdb/{grpc_server,grpc_client,grpc_test}.go — rpcdb gRPC adapter
- service/keystore/rpckeystore/ — keystore-over-gRPC (dead consumer)
- x/sync/ — entire merkledb sync engine (100% gRPC-tagged)
- internal/ids/rpcaliasreader/ — gRPC alias reader (dead consumer)
- connectproto/ — connect-go XSVM ping handler scaffolding
- vms/platformvm/warp/rpcwarp/{client,server}.go — gRPC warp signer
- vms/platformvm/network/warp.go — protobuf-based warp justification
handler (warp_zap.go retains the no-op verifier consumers expect)
- vms/components/message/message_grpc.go + message_test.go
- vms/example/xsvm/api/ping.go + vm_http_grpc.go + cmd/{run,xsvm}/
- wallet/network/primary/examples/sign-l1-validator-* (5 dead
example main packages)
- trace/{exporter_grpc,exporter_type,exporter_type_test,noop,tracer}.go
(OTLP gRPC exporter + duplicate Tracer types — trace_zap.go has
the canonical Tracer interface + no-op tracer)
- message/bft_grpc.go (Simplex BFT wrapper)
Edits (9 files): every surviving `_zap.go` drops its `//go:build !grpc`
constraint (the files are unconditional now) and drops stale
"ZAP version" / "ZAP mode" inline comments.
Doc updates:
- LLM.md ZAP Transport section: remove the `-tags=grpc` opt-in
language. Replace with "ZAP is the only wire protocol... there is
one and only one way". Update Latest Tag to v1.26.31. Update the
rpcdb topology section to reflect single-adapter state.
go.mod: connectrpc.com/connect, connectrpc.com/grpcreflect,
otlptracegrpc moved out of direct deps. google.golang.org/grpc +
protobuf demoted to indirect (still pulled transitively via luxfi/dex).
Verified:
- `go build ./...` (default, no tags) clean
- `go test ./db/rpcdb/... ./trace/... ./message/... ./vms/rpcchainvm/...
./vms/components/message/... ./vms/platformvm/network/...
./vms/example/xsvm/... ./service/keystore/... ./proto/...` clean
- `grep -rln '//go:build grpc' --include='*.go' node/` returns zero
- `grep -rln '//go:build !grpc' --include='*.go' node/` returns zero
- `grep -rln 'google.golang.org/grpc' --include='*.go' node/` returns
zero (only transitive deps remain in go.sum)
Pre-existing TestGraniteNetworkIDConfiguration failure in tests/ is
unrelated — fails on the parent commit too (verified via stash).
This commit is contained in:
@@ -8,7 +8,7 @@ Lux blockchain node implementation - a high-performance, multi-chain blockchain
|
||||
|
||||
**Key Context:**
|
||||
- Original Lux Network node — NOT a fork
|
||||
- Latest Tag: v1.26.12
|
||||
- Latest Tag: v1.26.31
|
||||
- Network ID: 96369 (Lux Mainnet), 96368 (Testnet), 96370 (Devnet)
|
||||
- Go Version: 1.26.1+
|
||||
- Database: ZapDB (primary, default)
|
||||
@@ -274,31 +274,33 @@ Located in `vms/thresholdvm/fhe/`:
|
||||
| Gateway | `0x0200000000000000000000000000000000000083` |
|
||||
|
||||
### ZAP Transport (Zero-Copy App Proto)
|
||||
ZAP is the default high-performance binary wire protocol for VM<->Node communication.
|
||||
gRPC support is available via build tag for testing/compatibility.
|
||||
ZAP is the only wire protocol for VM<->Node communication. The gRPC
|
||||
fallback (and its `-tags=grpc` opt-in) was retired in v1.26.31 along
|
||||
with every `//go:build grpc` file under `node/`. There is one and only
|
||||
one way to talk to a Chain VM: ZAP.
|
||||
|
||||
**Build Tags:**
|
||||
**Build:**
|
||||
```bash
|
||||
go build # ZAP only (default, production)
|
||||
go build -tags=grpc # gRPC support (for testing/compatibility)
|
||||
go build # ZAP only — there are no build tags
|
||||
```
|
||||
|
||||
**Key Packages:**
|
||||
- `github.com/luxfi/api/zap` - Core wire protocol and message types (Layer A)
|
||||
- `github.com/luxfi/proto/rpcdb` - rpcdb service spec / data carriers (Layer B)
|
||||
- `github.com/luxfi/node/db/rpcdb` - rpcdb Service + ZAP/gRPC transport adapters (Layer C)
|
||||
- `github.com/luxfi/vm/rpc/sender` - p2p.Sender over ZAP/gRPC
|
||||
- `vms/rpcchainvm/sender/` - Node-side sender implementation
|
||||
- `vms/platformvm/warp/zwarp/` - ZAP-based warp signing client/server
|
||||
- `github.com/luxfi/api/zap` — Core wire protocol and message types (Layer A)
|
||||
- `github.com/luxfi/protocol/rpcdb` — rpcdb service spec / data carriers (Layer B)
|
||||
- `github.com/luxfi/node/db/rpcdb` — rpcdb Service + ZAP transport adapter (Layer C)
|
||||
- `vms/rpcchainvm/sender/` — Node-side `p2p.Sender` over ZAP
|
||||
- `vms/rpcchainvm/zap/` — ChainVM client/server over ZAP
|
||||
- `vms/platformvm/warp/zwarp/` — Warp signing over ZAP
|
||||
|
||||
**rpcdb Layered Topology (post-2026-05 reorg):**
|
||||
- Layer A — wire framing: `github.com/luxfi/api/zap` (independent module)
|
||||
- Layer B — rpcdb service spec: `github.com/luxfi/proto/rpcdb` (transport-agnostic data carriers)
|
||||
- Layer C — rpcdb impl: `node/db/rpcdb/{service.go, grpc_server.go, zap_server.go}`
|
||||
**rpcdb Layered Topology:**
|
||||
- Layer A — wire framing: `github.com/luxfi/api/zap`
|
||||
- Layer B — rpcdb service spec: `github.com/luxfi/protocol/rpcdb`
|
||||
- Layer C — rpcdb impl: `node/db/rpcdb/{service.go, zap_server.go}`
|
||||
- `service.go` — transport-neutral `Service` wrapping `database.Database`
|
||||
- `zap_server.go` (default) — ZAP transport adapter (used by cevm)
|
||||
- `grpc_server.go` (`-tags=grpc`) — gRPC transport adapter
|
||||
- One Service, many transport adapters. Adding a transport = new file wrapping `*Service`.
|
||||
- `zap_server.go` — ZAP transport adapter (only adapter)
|
||||
- One Service, one transport. The dual-adapter pattern stays available
|
||||
for future transports (each is a new file wrapping `*Service`), but
|
||||
ZAP is the only one shipping.
|
||||
|
||||
**Wire Protocol Format:**
|
||||
```
|
||||
@@ -313,11 +315,8 @@ go build -tags=grpc # gRPC support (for testing/compatibility)
|
||||
|
||||
**Sender Usage:**
|
||||
```go
|
||||
// ZAP transport (default)
|
||||
// ZAP transport — the only transport
|
||||
s := sender.ZAP(zapConn)
|
||||
|
||||
// gRPC transport (requires -tags=grpc build)
|
||||
s := sender.GRPC(senderpb.NewSenderClient(grpcConn))
|
||||
```
|
||||
|
||||
**Warp over ZAP:**
|
||||
@@ -459,7 +458,7 @@ go test -v -run "TestHybrid" ./node/network/dialer/... -count=1
|
||||
|
||||
### 1. P2P Sender Interface
|
||||
Node's rpcchainvm implements `p2p.Sender` (from `github.com/luxfi/p2p`) for cross-chain messaging.
|
||||
The `sender` package is a gRPC implementation of `p2p.Sender`.
|
||||
The `sender` package is the ZAP-native implementation of `p2p.Sender`.
|
||||
|
||||
### 2. Chain Tracking
|
||||
Nodes don't automatically track chains. Use:
|
||||
|
||||
Reference in New Issue
Block a user