mirror of
https://github.com/luxfi/node.git
synced 2026-07-27 03:39:39 +00:00
External (HTTP / JSON-RPC) is the only place JSON is legitimate. Every
existing encoding/json import in node/ moves to github.com/go-json-experiment/json
(v2 root, not the v1 sub-package). NewEncoder/NewDecoder rewrite to
MarshalWrite/UnmarshalRead. MarshalIndent rewrites to Marshal with
jsontext.WithIndent. json.RawMessage rewrites to jsontext.Value.
*json.SyntaxError rewrites to *jsontext.SyntacticError.
81 files migrated. LLM.md captures the rule + v1->v2 delta table.
Known v2 semantic deltas surfaced by existing tests (followups, not regressions):
- [N]byte fields with no MarshalJSON now marshal as base64 string (v1 marshalled
as JSON array of byte numbers). Affects vms/platformvm/txs/*_test.go fixtures
with embedded BLS proofOfPossession.
- time.Duration has no v2 default representation; configs that wire-format
Duration as nanoseconds (vms/{xvm,platformvm}/config, config/spec) need to
switch to string-form Duration or carry an explicit option. v2 root does not
re-export FormatDurationAsNano.
- v2 enforces strict UTF-8 (vms/chainadapter/messaging fixture has non-UTF-8).
- json.MarshalWrite does not append a trailing '\n' (v1 NewEncoder.Encode did);
service/auth/auth_test.go expectation updated.
- nil []byte round-trips to empty (not nil); config_test deep-equal fixtures
surface this.
All affected sites are at the API boundary; ZAP wire envelope already covers
the internal data paths (state, P2P, consensus, MPC, threshold). Internal
JSON sites that should move to ZAP next (separate work):
- vms/da/store.go (DA blob/cert storage as JSON)
- vms/platformvm/airdrop (airdrop claims as JSON in db)
- vms/chainadapter/appchain (SQLite materializer schema/data blobs)
- vms/chainadapter/messaging (conversation codec)
- staking/kms.go (KMS HTTP client — external technically, leave)
- utils/{bimap,ips} (small marshaler shims — low priority)
74 lines
1.4 KiB
Go
74 lines
1.4 KiB
Go
// Copyright (C) 2019-2025, Lux Industries Inc. All rights reserved.
|
|
// See the file LICENSE for licensing terms.
|
|
|
|
package utils
|
|
|
|
import (
|
|
"github.com/go-json-experiment/json"
|
|
"net/netip"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
luxatomic "github.com/luxfi/atomic"
|
|
)
|
|
|
|
func TestAtomic(t *testing.T) {
|
|
require := require.New(t)
|
|
|
|
var a luxatomic.Atomic[bool]
|
|
require.Zero(a.Get())
|
|
|
|
a.Set(false)
|
|
require.False(a.Get())
|
|
|
|
a.Set(true)
|
|
require.True(a.Get())
|
|
|
|
a.Set(false)
|
|
require.False(a.Get())
|
|
}
|
|
|
|
func TestAtomicJSON(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
value *luxatomic.Atomic[netip.AddrPort]
|
|
expected string
|
|
}{
|
|
{
|
|
name: "zero value",
|
|
value: new(luxatomic.Atomic[netip.AddrPort]),
|
|
expected: `""`,
|
|
},
|
|
{
|
|
name: "ipv4 value",
|
|
value: luxatomic.NewAtomic(netip.AddrPortFrom(
|
|
netip.AddrFrom4([4]byte{1, 2, 3, 4}),
|
|
12345,
|
|
)),
|
|
expected: `"1.2.3.4:12345"`,
|
|
},
|
|
{
|
|
name: "ipv6 loopback",
|
|
value: luxatomic.NewAtomic(netip.AddrPortFrom(
|
|
netip.IPv6Loopback(),
|
|
12345,
|
|
)),
|
|
expected: `"[::1]:12345"`,
|
|
},
|
|
}
|
|
for _, test := range tests {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
require := require.New(t)
|
|
|
|
b, err := json.Marshal(test.value)
|
|
require.NoError(err)
|
|
require.Equal(test.expected, string(b))
|
|
|
|
var parsed luxatomic.Atomic[netip.AddrPort]
|
|
require.NoError(json.Unmarshal([]byte(test.expected), &parsed))
|
|
require.Equal(test.value.Get(), parsed.Get())
|
|
})
|
|
}
|
|
}
|