luxfi/geth
1
0
Fork 0
mirror of https://github.com/luxfi/geth.git synced 2026-07-27 01:59:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

geth/core/vm: use RegisterDefaultVerifier (CAS) for starkfri so the real p3q binding wins

Browse Source 
Was an unconditional RegisterVerifier(refuse) that clobbered the real starkfri verifier registered
by precompile/starkfri/init. Now registers a CAS-against-nil safe-refuse fallback that no-ops when
the real binding is present (atomic.Pointer). Fixes the init-order clobber.
This commit is contained in:
zeekay
2026-06-17 17:26:36 -07:00
parent 710dd4160f
commit fa8898a646
1 changed files with 20 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/vm/lux_precompiles.go
+20 -12
View File
@@ -312,27 +312,35 @@ func MergeLuxPrecompiles(base PrecompiledContracts) PrecompiledContracts {
// This includes standard Ethereum precompiles plus Lux-specific ones.
var PrecompiledContractsLux = MergeLuxPrecompiles(PrecompiledContractsCancun)
// init registers a safe-refuse stub for the strict-PQ STARK-FRI
// init registers a safe-refuse DEFAULT for the strict-PQ STARK-FRI
// verifier at boot.
//
// The real verifier is a CGO bridge into the Rust crate at
// ~/work/lux/p3q (Plonky3 fork, FRI over Goldilocks, cSHAKE256).
// That crate doesn't yet ship a `cdylib` build target + Go FFI; until
// it does, every node boots without a registered verifier and the
// precompile returns starkfri.ErrVerifierNotRegistered — safe-refuse,
// no forgery oracle.
// ~/work/lux/p3q (a post-quantum-only fork of Plonky3: FRI over
// Goldilocks, cSHAKE256 Merkle). It ships in the precompile package
// itself (precompile/starkfri/verify_cgo.go) and self-registers via an
// init() guarded by the `starkfri_p3q` build tag. Build a node with
// `-tags starkfri_p3q` (and link libp3q_c_abi.a) to get the real
// verifier; without the tag, the binding is excluded and this default
// keeps the precompile in safe-refuse (ErrVerifierNotRegistered ⇒ no
// forgery oracle).
//
// To wire the real verifier when the Rust FFI lands, replace the
// stub closure with the cgo entry point and rebuild geth. The
// registration call here is the single seam.
// Why RegisterDefaultVerifier (not RegisterVerifier): Go runs an
// imported package's init() before the importer's, so the real binding
// in precompile/starkfri wins the registration FIRST. An unconditional
// RegisterVerifier here would then CLOBBER the real verifier with the
// refuse stub. RegisterDefaultVerifier compare-and-swaps against "no
// verifier yet", so it no-ops when the real binding is present and only
// engages when it is absent — correct regardless of init order.
//
// The P3Q precompile at 0x012205 (Post-Quantum Pulsar Proof, LP-218)
// dispatches directly to the in-tree luxfi/crypto/mldsa verifier and
// does NOT require an FFI-registered verifier callback. No stub is
// does NOT require an FFI-registered verifier callback. No default is
// needed for P3Q.
func init() {
starkfri.RegisterVerifier(func(version byte, proof, pubInputs []byte) (bool, error) {
// Refuse-by-default. Real verifier slots in here.
starkfri.RegisterDefaultVerifier(func(version byte, proof, pubInputs []byte) (bool, error) {
// Refuse-by-default. The real cgo binding (built with
// -tags starkfri_p3q) registers ahead of this and wins the CAS.
return false, starkfri.ErrVerifierNotRegistered
})
}