mirror of
https://github.com/luxfi/node.git
synced 2026-07-27 03:06:23 +00:00
docs/postmortem: mark residual #1 (proposer-preference restart loop) FIXED
BuildBlock last-accepted fallback landed in 2dc15620e4 (ships v1.34.26).
Co-authored-by: Hanzo Dev <dev@hanzo.ai>
This commit is contained in:
@@ -141,6 +141,13 @@ No archive-mode workaround and no state-sync hack. Disk growth is unchanged
|
||||
`BuildBlock` then fails `not found` in a tight loop and the node's voter
|
||||
goes mute (observed ~170 err/s). Restart clears it. Fix: fall back to
|
||||
last-accepted when the preferred parent is not fetchable.
|
||||
**FIXED (commit `8001bc5179`, branch `ship/node-v1.34.24`, ships in
|
||||
v1.34.26):** `vms/proposervm/vm.go` `BuildBlock` now builds the child on
|
||||
last-accepted (always held — committed state) when `vm.preferred` is
|
||||
unfetchable, instead of hard-erroring; it surfaces the original error only
|
||||
when last-accepted is itself the unfetchable id. Build-side companion to the
|
||||
already-shipped defect #1 `SetPreference` validate-before-assign hardening.
|
||||
Tests: `vms/proposervm/vm_buildblock_fallback_test.go`.
|
||||
2. **Ancestor-fetch liveness:** the finality guard refuses certs with
|
||||
"ancestor … is not tracked (behind; fetch and retry)" but the fetch never
|
||||
fires, so the node loops instead of catching up. Restart clears it. Fix:
|
||||
|
||||
Reference in New Issue
Block a user