mirror of
https://github.com/luxfi/node.git
synced 2026-07-27 03:39:39 +00:00
Hanzo AI
c3b398bc7b
External (HTTP / JSON-RPC) is the only place JSON is legitimate. Every
existing encoding/json import in node/ moves to github.com/go-json-experiment/json
(v2 root, not the v1 sub-package). NewEncoder/NewDecoder rewrite to
MarshalWrite/UnmarshalRead. MarshalIndent rewrites to Marshal with
jsontext.WithIndent. json.RawMessage rewrites to jsontext.Value.
*json.SyntaxError rewrites to *jsontext.SyntacticError.
81 files migrated. LLM.md captures the rule + v1->v2 delta table.
Known v2 semantic deltas surfaced by existing tests (followups, not regressions):
- [N]byte fields with no MarshalJSON now marshal as base64 string (v1 marshalled
as JSON array of byte numbers). Affects vms/platformvm/txs/*_test.go fixtures
with embedded BLS proofOfPossession.
- time.Duration has no v2 default representation; configs that wire-format
Duration as nanoseconds (vms/{xvm,platformvm}/config, config/spec) need to
switch to string-form Duration or carry an explicit option. v2 root does not
re-export FormatDurationAsNano.
- v2 enforces strict UTF-8 (vms/chainadapter/messaging fixture has non-UTF-8).
- json.MarshalWrite does not append a trailing '\n' (v1 NewEncoder.Encode did);
service/auth/auth_test.go expectation updated.
- nil []byte round-trips to empty (not nil); config_test deep-equal fixtures
surface this.
All affected sites are at the API boundary; ZAP wire envelope already covers
the internal data paths (state, P2P, consensus, MPC, threshold). Internal
JSON sites that should move to ZAP next (separate work):
- vms/da/store.go (DA blob/cert storage as JSON)
- vms/platformvm/airdrop (airdrop claims as JSON in db)
- vms/chainadapter/appchain (SQLite materializer schema/data blobs)
- vms/chainadapter/messaging (conversation codec)
- staking/kms.go (KMS HTTP client — external technically, leave)
- utils/{bimap,ips} (small marshaler shims — low priority)
165 lines
4.3 KiB
Go
165 lines
4.3 KiB
Go
// Copyright (C) 2019-2025, Lux Industries Inc. All rights reserved.
|
|
// See the file LICENSE for licensing terms.
|
|
|
|
package staking
|
|
|
|
import (
|
|
"github.com/go-json-experiment/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
)
|
|
|
|
func TestFetchFromKMS(t *testing.T) {
|
|
wantKeys := KMSStakingKeys{
|
|
TLSKey: "-----BEGIN PRIVATE KEY-----\nfake-key\n-----END PRIVATE KEY-----",
|
|
TLSCert: "-----BEGIN CERTIFICATE-----\nfake-cert\n-----END CERTIFICATE-----",
|
|
SignerKey: "deadbeef",
|
|
}
|
|
|
|
secretValue, err := json.Marshal(wantKeys)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
kmsResponse := map[string]interface{}{
|
|
"secret": map[string]interface{}{
|
|
"secretValue": string(secretValue),
|
|
},
|
|
}
|
|
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
// Verify auth header
|
|
if auth := r.Header.Get("Authorization"); auth != "Bearer test-token" {
|
|
t.Errorf("expected Authorization header 'Bearer test-token', got %q", auth)
|
|
}
|
|
|
|
// Verify path
|
|
if r.URL.Path != "/api/v1/secrets/staking/test/node-0" {
|
|
t.Errorf("expected path '/api/v1/secrets/staking/test/node-0', got %q", r.URL.Path)
|
|
}
|
|
|
|
w.Header().Set("Content-Type", "application/json")
|
|
json.MarshalWrite(w, kmsResponse)
|
|
}))
|
|
defer server.Close()
|
|
|
|
keys, err := FetchFromKMS(KMSConfig{
|
|
Endpoint: server.URL,
|
|
SecretPath: "/staking/test/node-0",
|
|
AuthToken: "test-token",
|
|
})
|
|
if err != nil {
|
|
t.Fatalf("FetchFromKMS failed: %v", err)
|
|
}
|
|
|
|
if keys.TLSKey != wantKeys.TLSKey {
|
|
t.Errorf("TLSKey = %q, want %q", keys.TLSKey, wantKeys.TLSKey)
|
|
}
|
|
if keys.TLSCert != wantKeys.TLSCert {
|
|
t.Errorf("TLSCert = %q, want %q", keys.TLSCert, wantKeys.TLSCert)
|
|
}
|
|
if keys.SignerKey != wantKeys.SignerKey {
|
|
t.Errorf("SignerKey = %q, want %q", keys.SignerKey, wantKeys.SignerKey)
|
|
}
|
|
}
|
|
|
|
func TestFetchFromKMS_NoAuth(t *testing.T) {
|
|
kmsResponse := map[string]interface{}{
|
|
"secret": map[string]interface{}{
|
|
"secretValue": `{"tls_key":"k","tls_cert":"c","signer_key":"s"}`,
|
|
},
|
|
}
|
|
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
if auth := r.Header.Get("Authorization"); auth != "" {
|
|
t.Errorf("expected no Authorization header, got %q", auth)
|
|
}
|
|
w.Header().Set("Content-Type", "application/json")
|
|
json.MarshalWrite(w, kmsResponse)
|
|
}))
|
|
defer server.Close()
|
|
|
|
keys, err := FetchFromKMS(KMSConfig{
|
|
Endpoint: server.URL,
|
|
SecretPath: "/staking/test/node-0",
|
|
})
|
|
if err != nil {
|
|
t.Fatalf("FetchFromKMS failed: %v", err)
|
|
}
|
|
if keys.TLSKey != "k" {
|
|
t.Errorf("TLSKey = %q, want %q", keys.TLSKey, "k")
|
|
}
|
|
}
|
|
|
|
func TestFetchFromKMS_ServerError(t *testing.T) {
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.WriteHeader(http.StatusForbidden)
|
|
w.Write([]byte("access denied"))
|
|
}))
|
|
defer server.Close()
|
|
|
|
_, err := FetchFromKMS(KMSConfig{
|
|
Endpoint: server.URL,
|
|
SecretPath: "/staking/test/node-0",
|
|
})
|
|
if err == nil {
|
|
t.Fatal("expected error for 403 response, got nil")
|
|
}
|
|
}
|
|
|
|
func TestFetchFromKMS_EmptyEndpoint(t *testing.T) {
|
|
_, err := FetchFromKMS(KMSConfig{
|
|
SecretPath: "/staking/test/node-0",
|
|
})
|
|
if err == nil {
|
|
t.Fatal("expected error for empty endpoint, got nil")
|
|
}
|
|
}
|
|
|
|
func TestFetchFromKMS_EmptySecretPath(t *testing.T) {
|
|
_, err := FetchFromKMS(KMSConfig{
|
|
Endpoint: "https://kms.example.com",
|
|
})
|
|
if err == nil {
|
|
t.Fatal("expected error for empty secret path, got nil")
|
|
}
|
|
}
|
|
|
|
func TestFetchFromKMS_InvalidJSON(t *testing.T) {
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.Write([]byte("not json"))
|
|
}))
|
|
defer server.Close()
|
|
|
|
_, err := FetchFromKMS(KMSConfig{
|
|
Endpoint: server.URL,
|
|
SecretPath: "/staking/test/node-0",
|
|
})
|
|
if err == nil {
|
|
t.Fatal("expected error for invalid JSON, got nil")
|
|
}
|
|
}
|
|
|
|
func TestFetchFromKMS_InvalidSecretValue(t *testing.T) {
|
|
kmsResponse := map[string]interface{}{
|
|
"secret": map[string]interface{}{
|
|
"secretValue": "not-json-either",
|
|
},
|
|
}
|
|
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.Header().Set("Content-Type", "application/json")
|
|
json.MarshalWrite(w, kmsResponse)
|
|
}))
|
|
defer server.Close()
|
|
|
|
_, err := FetchFromKMS(KMSConfig{
|
|
Endpoint: server.URL,
|
|
SecretPath: "/staking/test/node-0",
|
|
})
|
|
if err == nil {
|
|
t.Fatal("expected error for invalid secret value JSON, got nil")
|
|
}
|
|
}
|